Repository navigation
[python] add bindings for rta::core::Spectrum - #363
Merged
antond-weta merged 1 commit intoOct 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 17 17
Lines 3876 3876
Branches 582 582
=======================================
Hits 3558 3558
Misses 318 318 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Expose spectral curves so Python callers can construct, resample, and combine them, and read channels from loaded spectral data. Assisted-by: Cursor / Grok 4.7 Assisted-by: Cursor / Claude Opus 5.5 Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
antond-weta
force-pushed
the
python-bind-spectrum
branch
from
October 18, 2026 20:06
c137998 to
873ebe3
Compare
antond-weta
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rta::core::SpectrumandSpectrum::Shapein the Python bindings, including construction, resampling, integration, and per-element arithmetic.SpectralData(data["name"],get, andin), and document the new types in the Python reference.Shapeunhashable because equality is by value.The bindings, tests, and docs were drafted in Cursor. A Claude Opus 5.5 review then asked for the shape check, unhashable
Shape, operatorNotImplementedbehavior, and clearerSpectralDatacontainment. Those review comments were applied before opening this PR.Assisted-by: Cursor / Grok 4.7
Assisted-by: Cursor / Claude Opus 5.5
Test plan
PYTHONPATH=build/src/bindings python3.14 -m pytest tests/pythonpython3.14 build_scripts/generate_python_docs.py --module-dir build/src/bindings --check-E -a -nMade with Cursor